I just submitted a pull request for my changes. It appears as unknown user, won't happen again.
On Nov 18, 4:11 pm, Klindel <[email protected]> wrote: > Sure, I'm not super familiar with git so I'll look into it. > > On Nov 16, 11:57 pm, Ruben Willems <[email protected]> wrote: > > > > > > > > > Hi > > > can you post your fix of the code? > > as a patch or the classes (you altered) > > > with kind regards > > Ruben Willems > > > On 17 November 2011 01:46, Klindel <[email protected]> wrote: > > > > I looked at the source code and it looks like it returns true if any > > > of the filters match, not all. So I wrote myself a multiFilter filter > > > that takes a list of filters and that only returns True if all filters > > > match. It solved my problem. > > > > On Nov 16, 12:22 pm, Ruben Willems <[email protected]> wrote: > > > > your setup seems ok to me > > > > > maybe it's a bug, > > > > need to check this > > > > > with kind regards > > > > Ruben Willems > > > > > On 9 November 2011 02:43, Klindel <[email protected]> wrote: > > > > > > I have an inclusionFilter and exclusionFilter set up for a project as > > > > > below: > > > > > > <inclusionFilters> > > > > > <pathFilter> > > > > > <caseSensitive>False</caseSensitive> > > > > > <pattern>$(depotRoot)/Data/*.xml</pattern> > > > > > </pathFilter> > > > > > <actionFilter> > > > > > <actions> > > > > > <action>delete</action> > > > > > </actions> > > > > > </actionFilter> > > > > > </inclusionFilters> > > > > > <exclusionFilters> > > > > > <pathFilter> > > > > > <pattern>$(depotRoot)/Data/*Instances*.xml</ > > > > > pattern> > > > > > </pathFilter> > > > > > <actionFilter> > > > > > <actions> > > > > > <action>edit</action> > > > > > <action>add</action> > > > > > </actions> > > > > > </actionFilter> > > > > > </exclusionFilters> > > > > > > What I expect to happen is that it will only trigger if a Data/*.xml > > > > > file is touched and it is delete and it doesn't have Instances in its > > > > > name. However, for me its triggering on any delete within the > > > > > sourceContro <view>. > > > > > > Is there something I have to do so that it'll only trigger when both > > > > > inclusions happen?
