Hi

sounds like a good fix,
if you can make a pull request, that would be very cool


with kind regards
Ruben Willems

On 15 August 2012 19:02, Michael Kelley <[email protected]> wrote:

> (Cross posting to ccnet-devel due to the modifications I've done.)
>
> It turns out the problem was the fact that the HTML attributes in the
> Bullseye CodeCoverage HTML report don't have quotes.  BuildFileDownload.cs
> has a regex that finds src and href attributes WITH quotes.
>
> Adding a regex that supports HTML files without quotes would be tricky and
> error prone so I've actually modified BuildFileDownload to use the
> HtmlAgilityPack (http://htmlagilitypack.codeplex.com/).  This seems to
> fix my problems and is much more robust than using a regex to parse HTML.
>  Do the CruiseControl maintainers want this change?
>
> On Friday, August 10, 2012 2:14:27 PM UTC-7, Michael Kelley wrote:
>>
>> I'm having trouble with relative files in the html files linked to by the
>> HtmlReportPlugin.  See below for the issue:
>>
>> http://stackoverflow.com/**questions/11909271/relative-**
>> links-not-working-in-**cruisecontrol-net-**htmlreportplugin<http://stackoverflow.com/questions/11909271/relative-links-not-working-in-cruisecontrol-net-htmlreportplugin>
>>
>>
>>
>>

Reply via email to