On Wed, 8 Aug 2012, Frederic Koehler wrote:
Some comments below:
> Thanks for the feedback; here are some revised patches
> and a third group of patches which fix enough segfaults
> by removing implicit function definitions
> to allow CDE to startup on x64, albeit to a very buggy desktop.
>
> ==================
> Avoid an infinite loop in ttsession (tooltalk daemon) when /etc/mtab
> is a symlink, using lstat instead of stat.
>
Applied.
[...]
> Define a final fallback for loading default window manager font;
> before exiting, forcefully try to load "fixed" font. This is sufficient
> to allow systems where fontList is set to an empty list to startup dtwm,
> for now.
>
Applied.
[...]
> Fix some implicit declarations of functions by adding appropriate
> #includes, etc. These implicit definitions cause segfaults on x64 because
> the implicit return type is a 32-bit signed int, rather than a pointer type.
Applied, though I had to do it manually since the above two patches
were also included again below, causing git to abort applying them. I
will have to write some guidelines on sending patches I think.
For the future (this applies to everybody, not just you):
1. Please send individual patches in separate emails. This makes it
easier for me to review and apply.
If you send a pile of patches in one email, then I end up having to
manually pull them apart and commit individually, which is time
consuming, error prone, and a royal PITA. :)
2. Please confine patches to specific areas and fixes... For example
the patches (protype related) should probably have been two
seperate emails - one for dtsvc, the other for dtwm patches. In
fact this particular email should have been a total of 4 seperate
emails, with their patches. (dtwm proto fix, dtsvc proto fix, lstat
fix, and dtwm font fix).
3. When in doubt, enclose the patch as a mime attachment.
4. For commit messages, I usually try to mention the subsystem, if
applicable, a short one line description of what the patch does,
then optionally, if needed, a more fuller description.
For example:
---
dtdbcache: remove incorrect comment block and tmpnam_buf var (not used)
With Aaron's fixes to dtdbcache fixing a potential coredump, the
comment block in the write_db() function regarding tmpnam() no longer
applies, and the tmpnam_buf variable is no longer used.
---
If others could follow this convention when supplying patches it
would make my job easier, since all I'd really need to do is
cut/paste. If the message is formatted properly, git can even
extract this info by itself apparently, though I haven't tried this
yet.
So, perhaps I'll formalize all of this in some seperate post.
Oh, and thanks for the fixes, they've been hitting alot of people! :)
[...]
--
Jon Trulson
"If the Martian rope-a-dope don't get him, he'll get himself, he'll
come in too fast and punch himself out."
- one of my brothers, referring to the Curiosity landing.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
