On Thu, 9 Aug 2012, ch...@chriswareham.net wrote:
> Hi folks, > > I enabled a bunch of warning flags in the Imake.tmpl file, including -Wall and > -Werror. This failed to bootstrap the build, since there were errors in the > config tools. Attached is a patch that makes imake and several of the utility > tools build with the following flags: > > -Wall -Werror -Wno-overlength-strings- -ansi -pedantic > > The overlength strings warning need to be disabled as there's a long string in > imake.c > > If anyone see any value in it, I am happy to continue cleaning up imake and > the > other build tools. If so, then I wonder if it's worth setting a baseline that > the systems the code is intended for should provide. For example, ANSI C, a > certain level of POSIX compatibility and so on. If so, then I could clean up a > lot of K&R style declarations and ifdef'ed code that copes with systems > without > varargs support. I agree that figuring out rules for this would be useful. There are plenty of places (in particular the numerous pointer/int conversions...) where the "right" thing to do will depend on what we're targetting. My $0.02: part of the value of CDE is that we can produce a more polished version of CDE for older systems (ones long since abandoned by KDE/GNOME/etc. but still in use), so maybe we shouldn't set the bar *too* high. -Rob ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ cdesktopenv-devel mailing list cdesktopenv-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel