Comments inline

Peter

On Tue, Aug 14, 2012 at 12:34:22AM +0200, Marcin Cieslak wrote:
> dtksh can be 

<snip>

> 
> diff --git a/cde/programs/Imakefile b/cde/programs/Imakefile
> index ca66a8b..e80beb2 100644
> --- a/cde/programs/Imakefile
> +++ b/cde/programs/Imakefile
> @@ -12,10 +12,12 @@ EXTRADIRS += util
>  
>  XCOMM some of these cannot be built on linux yet.
>  XCOMM dtksh dtinfo
> -#if defined(LinuxArchitecture) || defined(OpenBSDArchitecture) || 
> defined(FreeBSDArchitecture)
> +#if defined(LinuxArchitecture) || defined(OpenBSDArchitecture)
>  DTKSHDIR = 
>  DTINFODIR = 
> -#else
> +#elif defined(FreeBSDArchitecture)
> +DTKSHDIR = dtksh
> +DTINFODIR = 
>  DTKSHDIR = dtksh
>  DTINFODIR = dtinfo
>  #endif

Missing #else for non-bsd/non-linux platforms

<snip>

> --- a/cde/programs/dtksh/ksh93/ship/shipin
> +++ b/cde/programs/dtksh/ksh93/ship/shipin
> @@ -728,110 +728,6 @@ esac
>  trap 'exit 2' 1 2
>  
>  #
> -# check if we can use pax -- punt to cpio
> -#

Any idea what this code was for before we chuck it?

<snip>

> --- a/cde/programs/dtksh/ksh93/src/cmd/ksh93/edit/vi.c
> +++ b/cde/programs/dtksh/ksh93/src/cmd/ksh93/edit/vi.c
> @@ -124,7 +124,6 @@
>  
>  #define      MAXCHAR MAXLINE-2               /* max char per line */
>  
> -#undef isblank

Do you still need to do this if you're renaming isblank to kshisblank() 
below?

>  #ifdef SHOPT_MULTIBYTE
>      static int bigvi;
>  #   define gencpy(a,b)       ed_gencpy(a,b)
> @@ -134,14 +133,14 @@
>  #   define is_print(c)       ((c&~STRIP) || isprint(c))
>      static int isalph __PROTO__((int));
>      static int ismetach __PROTO__((int));
> -    static int isblank __PROTO__((int));
> +    static int kshisblank __PROTO__((int));



-- 
Peter Howkins
peter.howk...@marutan.net

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

Reply via email to