On 14 August 2012 at 12:01 "ch...@chriswareham.net" <ch...@chriswareham.net>
wrote:
> Attached patch has seen a make clean && make World on my machine. There
> remains a signed / unsigned comparison issue, where an unsigned short is being
> read from an RPC message and then assigned to either a uid_t or gid_t, which
> are then compared to -1. This causes a warning when compiling the
> lib/tt/lib/db/tt_old_db.C source file. Comparisons of uid_t and gid_t types
> (which are unsigned on x86 Linux) to -1 occur elsewhere, but the warnings are
> masked by casts. Not sure whether these comparisons are a problem or not.
>
> Chris
>
>
Needs the attached patch as well. Can't change the signature of an RPC
generated stub ...
Chris
From 57ff4c0cecce686b6810e3e826b3e8e34f65a5ee Mon Sep 17 00:00:00 2001
From: Chris Wareham <ch...@chriswareham.net>
Date: Tue, 14 Aug 2012 12:59:44 +0100
Subject: [PATCH] Have to pass a const char * to function expecting char *
here, otherwise it fails to link thanks to the declaration
of a stub wth non-const param.
---
cde/lib/tt/lib/db/db_server.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cde/lib/tt/lib/db/db_server.h b/cde/lib/tt/lib/db/db_server.h
index 63b66cb..cd3b675 100644
--- a/cde/lib/tt/lib/db/db_server.h
+++ b/cde/lib/tt/lib/db/db_server.h
@@ -862,7 +862,7 @@ bool_t xdr_tt_garbage_collect_results(XDR *, _tt_garbage_collect_results *);
#include "db/tt_db_client_utils.h"
-extern int *_tt_min_auth_level_1(const char**, CLIENT*, clnt_stat *status);
+extern int *_tt_min_auth_level_1(char**, CLIENT*, clnt_stat *status);
extern _Tt_isam_results *_tt_isaddindex_1(_Tt_isaddindex_args*, CLIENT*);
extern _Tt_isam_results *_tt_isbuild_1(_Tt_isbuild_args*, CLIENT*);
extern _Tt_isam_results *_tt_isclose_1(int*, CLIENT*);
--
1.7.11.2
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
