No, see my other changes, I malloced execstr.
On Fri, Aug 17, 2012 at 5:09 AM, Marcin Cieslak <sa...@saper.info> wrote:
> On Thu, 16 Aug 2012, Frederic Koehler wrote:
>
>> Fix some more obvious bugs; unfortunately, they don't seem to be behind
>> dtcreate's current brokenness.
>>
>
> I would be careful here:
>
> @@ -278,6 +278,7 @@ char linebuf[1024],**wordPairs,**execstr;
> {
> ActionDataptr->pszCmd = execstr[0];
> ActionDataptr->pszPrompt = execstr[1];
> + free(execstr);
> }
>
> I am not sure execstr (returned by ProcessExecString) is no heap.
>
> It returns a pointer to internal automatic variable :/
>
> Maybe this whole thing should be changed to use caller-supplied
> char *[3] for output?
>
>
> //Marcin
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
