On Tue, 18 Sep 2012, Jon Trulson wrote:

> On Tue, 18 Sep 2012, Marcin Cieslak wrote:
> 
> Well, it will be a problem for anyone that does not have a built motif
> src tree symlinked into imports...

This is necessary only to developers needing to update XmPrivate.h only.
The build should work without Motif sources at all (and it works for me).

> > Does symplinking of "openmotif-2.3.3/lib"
> > in to "imports/motif/lib" work for you?
> > 
> 
> I'm not sure how that would help... Perhaps you meant motif/include?

No, one needs openmotif-2.3.3/lib/Xm to be accessible because it contains
the "internal" *.h files. But this in only - again - needed
*only* if you modify extractprototype.awk

> During the last git am of your patch, followed by a make World, the
> file was deleted, causing the build to fail.  Probably due to the fact
> that the awk script was updated, and the Imakefile makes XmPrivate.h
> dependant on the awk script.

I cannot reproduce your results - can you send me a full log
of such a build (checking out older version and "git am" on it)?

> I just disabled this altogether in Linux - though I think it should be
> disabled all of the time on all systems.
> 
> IMO, the awk script that generates XmPrivate.h should always only be
> run manually when it's needed, and never automatically.  The only way
> it can ever work automatically is with an openmotif source tree, built
> and symlinked into imports.

make should never regenerate XmPrivate.h unless:
- it is missing
- extractprototype.awk is *newer* than XmPrivate.h

> That will never be the usual case on Linux, and probably most other
> systems as well.  I think fbsd is special in this regard since it's
> all done via the ports system.

We don't do anything with ports here. I have tried now complete
build with BSD make as well as with GNU make. The last one fails
at the end with the "doc" generation (which I will investigate), but both
builds do not re-generated XmPrivate.h at all.

I did the test using:

git clone git://git.code.sf.net/p/cdesktopenv/code clean_cde
cd clean_cde/cde
git checkout -b testam 5e14a88
mkdir -p imports/x11
ln -s /usr/local/bin /usr/local/include /usr/local/lib imports/x11
mkdir -p imports/motif/include
ln -s /usr/local/include/Xm imports/motif/include
git am <patch-extracted-from-the-email>
make World

it results in the following in the "include/Xm" directory:

With BSD make:

including in include/Xm...
+ mkdir -p ../../exports/include/Xm
+ cd ../../exports/include/Xm
+ rm -f XmPrivate.h
+ ln -s ../../../include/Xm/XmPrivate.h .
including in ./lib...

With GNU make:

including in include/Xm...
gmake[3]: Entering directory 
`/.amd_mnt/radziecki/a/icybox/tmp/clean_cde/cde/include/Xm'
+ mkdir -p ../../exports/include/Xm
+ cd ../../exports/include/Xm
+ rm -f XmPrivate.h
+ ln -s ../../../include/Xm/XmPrivate.h .
gmake[3]: Leaving directory 
`/.amd_mnt/radziecki/a/icybox/tmp/clean_cde/cde/include/Xm'
gmake[2]: Leaving directory 
`/.amd_mnt/radziecki/a/icybox/tmp/clean_cde/cde/include'
including in ./lib...

File have the same timestamp:

-rw-rw-r--  1 saper  saper   5174 Sep 18 20:56 XmPrivate.h
-rw-rw-r--  1 saper  saper   1728 Sep 18 20:56 extractprototype.awk

so XmPrivate.h *does not* get re-generated and Motif sources
are *not* needed

It is not very unusual to have files generated in the build
this way so I wonder why it fails for you.

Full logs of mine are available here:

http://saper.info/files/cdesktopenv/build_logs/xmprivate-build-log-bsdmake.gz
http://saper.info/files/cdesktopenv/build_logs/xmprivate-build-log-gnumake.gz

I am pretty sure we will be adding more functions
added to XmPrivate.h so I'd love to have all those
problems solved.

//Marcin

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

Reply via email to