On Fri, 28 Sep 2012, Marc Balmer wrote:
> for patch 1: don't roll your own strfunctions, use strlcpy or so
I'm inclined to apply this - strlcpy isn't available on all systems
(on linux, requires bsd lib I think). In addition, strlcpy also does
not permit overlapping buffers, based on a google search. Was
valgrind detecting overlapping buffers? Did it fix a problem?
> for patch 2: hunk 1 and 3 are not needed
>
>
Yeah, not sure about this one either... Confused.
Marc says 1 and 3 are not needed, but if you omit them, then 2 cannot
work otherwise. I wonder if this is the real problem? Is this on a
64b machine? I wonder if this patch just moved the problem somewhere
else?
Comments on either of these?
--
Jon Trulson
The Higgs Field is what make atoms matter.
-- Tom L.
------------------------------------------------------------------------------
How fast is your code?
3 out of 4 devs don\\\'t know how their code performs in production.
Find out how slow your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219672;13503038;z?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
