Hello,

the last patches are very nice, but they have some problems on FreeBSD:

The first one is simple (see attached patch):
    a type definition for time_t was missing.

Other problems with lib/DtHelp have significance only in dtinfo and I
could solve them inside of dtinfo.

The last nsgmls related problem is more complicated. The -fpermissive
is needed on 32bit systems. On these systems size_t and unsigned int have the same size and therefore in parser_inst.m4 we have identical instantiations:
    __instantiate(Vector<size_t>)
    __instantiate(Vector<unsigned int>)
The compiler doesn't like it and aborts. The -fpermissive prevented
him to do so, but of course that's a bad solution.

But a good solution is difficult. 32bit systems only need one of the
instantiations above and 64bit systems need both. I would suggest
something like this:
    __instantiate(Vector<size_t>)
    #if defined (__LP64__)
    __instantiate(Vector<unsigned int>)
    #endif
It covers many platforms like amd64, sparc, alpha, but not everything. I'm afraid that OpenBSD's powerpc port is not covered.
I've found __powerpc64__ in the OpenBSD sources. Could that be a
solution? I don't have ppc hardware and cannot test it.

Regards, Ulrich


--
Ulrich Wilkens
Email: m...@uwilkens.de

>From 20c1b8f66ac2578da273783faf66c11a599d82be Mon Sep 17 00:00:00 2001
From: Ulrich Wilkens <m...@uwilkens.de>
Date: Thu, 25 Jul 2013 01:09:25 +0200
Subject: [PATCH] lib/DtHelp: added missing include.

---
 cde/lib/DtHelp/Obsolete.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cde/lib/DtHelp/Obsolete.c b/cde/lib/DtHelp/Obsolete.c
index 398cd88..61eac03 100644
--- a/cde/lib/DtHelp/Obsolete.c
+++ b/cde/lib/DtHelp/Obsolete.c
@@ -48,6 +48,7 @@
  * system includes
  */
 #include <stdlib.h>
+#include <unistd.h>
 
 /*
  * Canvas Engine
-- 
1.7.11.5

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

Reply via email to