On Thu, 20 Feb 2014, Ulrich Wilkens wrote:
Hello,this is a larger patch. It is a port to NetBSD, tested on version 5.1.2 and 6.1.2. !! It additionally requires build instructions in the wiki. Included are also some fixes for build warnings on other platforms (sym2num warnings).
Yep, it is rather large, but that's the way it goes :) The only problem I have with this patch is the removal of the NO_DTINFO blocks in programs/types/dtwm.fp.src. While you removed the code in the Imakefile that might define this (which I'm okay with), I think you removed the wrong lines from dtwm.fp.src. The idea was that on systems where dtinfo could not be built or didn't work, this could be defined so that the dtwm FP would show the help panel and subpanel in it's place. If NO_DTINFO was NOT defined, then the default of having the dtinfo panel and it's subpanel would show. These are the blocks you removed. I would prefer to keep these blocks as is -- for cases in the future where someone is porting this and they do not want to (or just can't) enable dtinfo on the FP. As long as NO_DTINFO is undefined, the default behavior of having the dtinfo panel and subpanel on dtwm's FP would work. -- Jon Trulson "It is a truism that almost any sect, cult, or religion will legislate its creed into law if it acquires the political power to do so." —Robert A. Heinlein, science-fiction author (1907-1988)
------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________ cdesktopenv-devel mailing list cdesktopenv-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
