Sorry about all these email, but here is a quick patch for some stuff I forgot.
Thank you for your time,
-Chase
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On April 23, 2018 8:05 PM, Chase via cdesktopenv-devel
<cdesktopenv-devel@lists.sourceforge.net> wrote:
> For some reason the csh to sh commit part of my previous commit was left out,
> but I guess it makes sense to make it it's own commit, so here. Debian frowns
> upon csh scripts in the source directory, and it is generally a bad practice
> to write scripts in csh, so I replaced a few instances of csh with sh and
> rewrote a few scripts.
>
> Thank you for your time,
> -Chase
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On April 23, 2018 4:43 PM, Chase <nicetry...@protonmail.ch> wrote:
>
>> Not quite sure why my license file turned into a binary, take this one
>> instead.
>>
>> Thank you for your time,
>> -Chase
>>
>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>> On April 23, 2018 4:38 PM, Chase via cdesktopenv-devel
>> <cdesktopenv-devel@lists.sourceforge.net> wrote:
>>
>>> Hi all,
>>>
>>> I actually sent out this email about a week ago, but accidentally sent it
>>> to only one person, I do have some small additions to my progress though. I
>>> have some patches attached to this email, mostly spelling fixes and code
>>> cleanup.
>>>
>>> I want to provide a small update on some progress I've made on the package,
>>> but first I want to say thank you to Jon for fixing dtbuilder and the
>>> rpcbind situation, great work!
>>>
>>> I have an update on the instant situation, instant makes, but only cleans
>>> when run inside the folder, when clean is run at the cde top folder, it
>>> doesn't clean, thus triggering the error.
>>>
>>> Next, a problem I forgot to mention, many of the files are missing
>>> copyright headers, I will attach a text file with all the files, because
>>> this email is long enough as it stands.
>>>
>>> The next issue is a reevaluation of the dependencies on debian systems. The
>>> wiki states that git is needed to download and build the software, but you
>>> can download a snapshot of the most current repository or any older
>>> repositories without git. Build essentials is stated to also be needed, but
>>> debian and debian based systems already provides this at install. On
>>> debian, software is depended on in three ways, it can be depended, which
>>> means that the package will flat out not work unless this software is
>>> installed, recommended, which means the package may suffer breakages
>>> without it, but still functions, and suggests, which means the package will
>>> not suffer any problems if the dependency is not met and is merely an
>>> enhancer. The qualifiers should be specified in the wiki or to me directly
>>> so I can build the package properly, because putting these in the wrong
>>> categories can cause problems. Putting xfonts in depends, for example,
>>> makes lintian throw an error, because it is extremely rare for a program to
>>> cease functionality altogether simply due to a missing font, so it either
>>> goes into recommends or suggests depending on if functionality is missing
>>> without it, so I am putting it into recommended unless someone can let me
>>> know if CDE still works without it, or on the flipside, is written in a way
>>> in which CDE will not function at all without them. I would test these
>>> dependencies myself, but I have been busy building the package and writing
>>> documentation, I am going to ask the package sponsors to join this mailing
>>> list and maybe they will be able to provide insight into the situation.
>>> libssl seems to be completely pointless, and can be removed from the
>>> dependency list, I did a quick grep through the code and there is no code
>>> relating to libssl. Tcl also seems to be minimally used, only appearing in
>>> /programs/dtdocbook/tcl/*, this is by no means a priority, but if someone
>>> could write tcl out of those files in that folder that would eliminate one
>>> more needless dependency. Ksh and it's related programs should also be a
>>> bit more shell independent if at all possible as to eliminate to dependency
>>> on ksh, but again, that isn't the biggest issue as of now. I haven't looked
>>> much into the other dependencies, but I am sure some of them could be put
>>> into recommended, suggested, or removed entirely.
>>>
>>> As for the /usr/dt situation, I understand that backwards compatibility is
>>> an important issue when it comes to scripts, but on the flip side, many
>>> unix platforms simply use older versions of CDE as it is, so those who want
>>> a current offering probably won't be affected and those who want to
>>> maintain backwards compatibility are still using CDE 1.0. As for /usr/dt
>>> being the standard, I looked around, and not from POSIX, SUS, IEEE, ISO or
>>> FHS could I find a single reference to /usr/dt being the standard directory
>>> for CDE, the closest thing I could find to a CDE standard was ISO 1295 for
>>> motif, but it has since been withdrawn. It may have been the standard back
>>> in the 1990s, however it is not today, and should be made to (ironically)
>>> comply with modern day standards. I have two desktops installed on my
>>> system, lxde and lxqt, both of them put data from usr into their respective
>>> subcategories, /usr/share, /usr/bin, /usr/lib, and none of them define
>>> something like /usr/lxde/* and put all the files there, so a quick fix
>>> would be replacing all the hardcoded dt stuff with it's proper place in
>>> usr, but unfortunately, /usr/dt can not remain if a debian package is still
>>> desired, I could ask my sponsors if they would be willing to override the
>>> issue, but an override usually comes with the presumption that the issue
>>> will be fixed soon or that attempting to fix the problem would break
>>> functionality so badly it would be counterproductive. The latter statement
>>> does not seem to be true, and thus it would only be putting off a fix.
>>> Also, as for /etc/dt and /var/dt, these are fine and debian doesn't throw
>>> any errors, however, /var/dt could be broken up even further into the
>>> provided subdirectories, but /var/dt is valid as of now. As for symlinking,
>>> I think that it would be the equivalent of putting a painting on a hole in
>>> the wall. The DESTDIR problem is more of an inconvenience more than
>>> anything, this is the bug that referenced it:
>>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=689098
>>>
>>> As for infolib, C and ja, debuild creates a fake root in the package's
>>> files in order to test the package, maybe this is some sort of glitch
>>> regarding build location? The errors being given to me say that when the
>>> package is installed, these directories are being installed on root.
>>>
>>> I've been busy as of late getting some install scripts to work, I tried
>>> some from a package made by a sparkylinux maintainer, however those scripts
>>> throw more errors than they are worth, so I will be looking at implementing
>>> the ones provided by CDE. Debian is now throwing errors about the recursive
>>> chown, (chmod -R a+rwx /var/dt for a post install script) Debian gives
>>> these suggestions in order to replace recursive chown:
>>> - If your package uses a static uid, please perform the chown at
>>> package build time instead of installation time.
>>> - Use a non-recursive call instead, ensuring that you do not change
>>> ownership of files that are in user-controlled directories.
>>> - Use runuser(1) to perform any initialization work as the
>>> user you were previously chowning to.
>>>
>>> I tried the verbose mode on lintian to see if I could get more info from
>>> these errors, however the verbose mode only seems to enable color coding
>>> and other non-important details, and no important information.
>>>
>>> As for the compiler warning thing, I did not mean to put down any work on
>>> compiler and coverity warning work, it is important work that fixes many
>>> security problems and I apologize if I came off that way, I just saw that
>>> almost all work was being done on compiler and coverity warnings, and
>>> assumed that was the main focus, goes to show you shouldn't assume things!
>>>
>>> Thank you for your time,
>>> -Chase
>>>
>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>> On April 12, 2018 6:13 AM, Chase via cdesktopenv-devel
>>> <cdesktopenv-devel@lists.sourceforge.net> wrote:
>>>
>>>> Hi all,
>>>> I was advised to share a project of mine with this mailing list, as people
>>>> may find it helpful and have things to add. I am normally opposed to
>>>> having my private email be available to the public, but I will make an
>>>> exception in this case. I have been working on a CDE package for Debian as
>>>> of recent, and would like to share some of my progress. Good news is, the
>>>> package builds and with some proper tweaking works without any major
>>>> issues. The bad news is, is that Debian's standards for packages
>>>> immediately disqualifies the package due to a number of issues. Luckily
>>>> that number is small, but there are some sizable issues. The issues are as
>>>> follows:
>>>>
>>>> - Non standard directory creation - this includes the directories C, ja,
>>>> and infolib on root and the existence of /usr/dt. The contents of C and ja
>>>> seem to be the exact same, so perhaps their functionality can be merged
>>>> and moved elsewhere, infolib doesn't seem to have much of anything in it,
>>>> and I don't really see the purpose of it's existence. /usr/dt is the
>>>> biggest problem facing a CDE package. The short term simple solution would
>>>> be to find a different place to store it in a standard directory, but the
>>>> goal would be to specify a directory via the build mechanism, however CDE
>>>> ignores DESTDIR, so this could be difficult.
>>>> - Missing source code (supposedly) - Lintian, when checking for errors in
>>>> the built package, finds binaries for dtbuilder and instant, and says that
>>>> they are missing source code due to them being in binary format, but both
>>>> of them have code. I suspect that for dtbuilder, this is an issue relating
>>>> to a case mismatch in the makefile, it builds "dtbuilder" but cleans
>>>> "Dtbuilder", and thus when I run clean, it will not clean. As for instant,
>>>> I still have to look into it a bit further as it makes and cleans just
>>>> fine.
>>>> - Binaries defining rpath - dsdm, dtdspmsg, dtsrclean, dtsrcreate,
>>>> dtsrdbrec, dtsrdelete, dtsrhan, dtsrindex, dtsrkdump, dtsrload, huffcode,
>>>> imake and nsgmls all define rpath to /usr/lib, debian explains why this is
>>>> a problems here: https://wiki.debian.org/RpathIssue
>>>>
>>>> - Package has unnecessary activation of ldconfig trigger, this might be an
>>>> issue with CDE or a bug in lintian, I still need to look into it more.
>>>> - libssl - Package makes use of libssl, I need to find out to what degree,
>>>> and if it is actually a dependency like the wiki says, I will ignore it
>>>> for now as trying to get the correct dependency on my system is for some
>>>> reason a challenge. If libssl is truly needed for the project, the license
>>>> must include a linking exception clause as displayed here:
>>>> https://en.wikipedia.org/wiki/OpenSSL#Licensing
>>>>
>>>> Some issues that are not blocking a release but are frowned upon by Debian:
>>>>
>>>> - Being a git release, since 2.2.4 isn't going to be seeing any of the
>>>> issues above patched, and also a few people tested 2.2.4 without libxp and
>>>> it fails to build, whereas the new build works. I decided to use the git
>>>> release, however this is frowned upon due to one of Debian's goals is
>>>> being stable.
>>>> - Setting rpcbind to insecure, maybe be fixable with some tweaks in
>>>> libtirpc.
>>>> - CVEs, although I know that with the first one mentioned, it was patched
>>>> by ibm and some other unix companies, does anyone have connections with
>>>> them and would be willing to ask them for the patch? They may even have
>>>> one for the second CVE as well.
>>>>
>>>> The main issues being worked on are compiler and coverity warnings, which
>>>> means that these issues are being put on hold until further notice unless
>>>> me or someone else decides to pick them up, so please le me know if you
>>>> are interested.
>>>>
>>>> Thank you for your time,
>>>> -Chase
From 3bad52f02119d715ea11fb9851227b2a0fb2601c Mon Sep 17 00:00:00 2001
From: chase <ch...@localhost.com>
Date: Mon, 23 Apr 2018 22:41:14 -0700
Subject: [PATCH] Small spelling fixes
---
cde/examples/motif/draganddrop/DNDDemo.c | 2 +-
cde/examples/motif/draganddrop/DNDDemo.h | 2 +-
cde/lib/DtTerm/util/lineToData.c | 2 +-
cde/programs/dtlogin/sysauth.c | 2 +-
cde/programs/dtmail/dtmail/RunLocalBento | 4 ++--
5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/cde/examples/motif/draganddrop/DNDDemo.c b/cde/examples/motif/draganddrop/DNDDemo.c
index 717d424b..b0a1e166 100644
--- a/cde/examples/motif/draganddrop/DNDDemo.c
+++ b/cde/examples/motif/draganddrop/DNDDemo.c
@@ -44,7 +44,7 @@ static char rcsid[] = "$XConsortium: DNDDemo.c /main/4 1995/10/27 10:43:34 rswis
/*
- * The folowing character arrays are for use with the drop help
+ * The following character arrays are for use with the drop help
* dialogs. For internationalization, message catalogs should
* replace these static declarations.
*/
diff --git a/cde/examples/motif/draganddrop/DNDDemo.h b/cde/examples/motif/draganddrop/DNDDemo.h
index 236a9120..f7da85cf 100644
--- a/cde/examples/motif/draganddrop/DNDDemo.h
+++ b/cde/examples/motif/draganddrop/DNDDemo.h
@@ -192,7 +192,7 @@ extern unsigned char SMALL_STATE_ICON_BITS[];
extern unsigned char SMALL_STATE_ICON_MASK[];
extern unsigned char SMALL_INVALID_ICON_BITS[];
-/* The folowing character arrays are for use with the drop help
+/* The following character arrays are for use with the drop help
* dialogs. For internationalization, message catalogs should
* replace these static declarations.
*/
diff --git a/cde/lib/DtTerm/util/lineToData.c b/cde/lib/DtTerm/util/lineToData.c
index 0240f2c3..33fd4b29 100644
--- a/cde/lib/DtTerm/util/lineToData.c
+++ b/cde/lib/DtTerm/util/lineToData.c
@@ -417,7 +417,7 @@ parseCoord(char **str, char *val, signed char *offset)
sign = -1;
/* skip over sign... */
(void) c++;
- /* skip over shitespace... */
+ /* skip over whitespace... */
while (*c && strchr(" \t", *c))
c++;
diff --git a/cde/programs/dtlogin/sysauth.c b/cde/programs/dtlogin/sysauth.c
index 801138b9..a21d146b 100644
--- a/cde/programs/dtlogin/sysauth.c
+++ b/cde/programs/dtlogin/sysauth.c
@@ -2250,7 +2250,7 @@ Authenticate( struct display *d, char *name, char *passwd, char **msg )
return(VF_PASSWD_AGED);
/* These 3 cases should allow user to select a new password */
- /* after displaying a warrning, but current implementation */
+ /* after displaying a warning, but current implementation */
/* only displays the warning. */
case MANDATORY:
diff --git a/cde/programs/dtmail/dtmail/RunLocalBento b/cde/programs/dtmail/dtmail/RunLocalBento
index eb6fca71..a84ee735 100644
--- a/cde/programs/dtmail/dtmail/RunLocalBento
+++ b/cde/programs/dtmail/dtmail/RunLocalBento
@@ -1,7 +1,7 @@
-#!/bin/csh -f
+#!/bin/sh -f
#
# A script that aids in debugging and testing dtmail
-#
+
if [ `uname -s` != SunOS ]
then
echo "Only support SunOS"
--
2.17.0
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
