On 06/01/18 03:32, Matthew R. Trower wrote:
If there must be two otherwise identical files, perhaps they should be
auto-generated from a master source? Perhaps using m4 or the like (or even a
simple script using cat + sed to pre-pend the appropriate header --- I'm happy
to write this up and submit it). This would incur some (hopefully marginal)
complexity, but avoid maintenance costs associated with code duplication.
Yes, auto-generated files would be nice. I also don't like redundant files.
That's why I did not do the simple patch by myself.
But prepending the header wouldn't work because then you have the main part
without a header.
And that seems to be a problem. I don't know why, but I'm not a lawyer.
--- Matthew R. Trower
Original Message
From: Ulrich Wilkens
Sent: Thursday, May 31, 2018 20:25
To: cdesktopenv-devel@lists.sourceforge.net
Subject: Re: [cdesktopenv-devel] [PATCH] Fix Linux rpc problems with new glibc
On 06/01/18 02:18, Jon Trulson wrote:
On 05/31/2018 03:49 PM, Ulrich Wilkens wrote:
The second patch mainly cares about removed sunrpc support in glibc.
This is a problem on newest Linux releases.
It also fixes some new warnings.
Applied to master.
I've also removed the shortly added license header in
cde/programs/dtinfo/dtinfo/src/Registration.hh
This file is included in a message file and gencat complains
about the new header lines.
If the license info is really needed, it could be added in another
way later. But for now, I've just removed it.
Ok. We could also re-add it, but use the msgcat commenting style "$ " -
ie, a line beginning with a $ followed by a single space...?
Yes, I think that should be the solution. But then we need two files.
One for inclusion in c++ files and the other one for inclusion in
msg the file. Both should have the corresponding header format, otherwise
they should be the same.
The new file has to be included in
programs/dtinfo/dtinfo/src/dtinfo_msg.tmpl
Thanks!
-jon
Best Regards, Ulrich
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
--
Ulrich Wilkens
Email: m...@uwilkens.de
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
