I've applied this to master. I didn't go through the site.def/host.def route because this is the only place it will ever be used.

Thanks!
-jon

On 10/25/18 4:20 AM, Matthew R. Trower wrote:
Jon Trulson <j...@radscan.com> writes:

This also means that Solaris/Sun and NetBSD will no longer build when
I merge the commit.  It will be up to the people that maintain/use CDE
for them to send a patch as I do not have those systems available.

So this is a "heads-up" to them as well.

Hopefully it should be a simple matter of installing the right package
(and updating the OS wiki page) and adding the correct stanza to
programs/dtdocbook/instant/Imakefile.

OpenIndiana/OpenSolaris build fine (tcl 8.6/8.4), with -ltcl.  Users
will of course need to install tcl, and also symlink a default version
(libtcl.so -> libtcl8.x.so), as I would prefer not to hardcode a
dependency on some specific tcl.

After some consideration, this patch does not add an architectural
condition for Sun.  Instead, it sets TCLLIB = -ltcl by default, as all
platforms will need *something* there, and that one seems most sensible.
I also added an override block, so a user can set overrides in, say,
host.def.

For example:

<host.def>
#define TCLInc -I/usr/local/include/tcl8.7
#define TCLLib -ltcl87
--------


This could probably be better.  Probably, the defaults should be set in
site.def or such; architecture overrides should be in linux.cf,
freebsd.cf, etc; and the actual make variables should be defined in some
.tmpl file somewhere, as is standard in this codebase.  But I'm not sure
on all of the specifics, and I think this is still an incremental
improvement.  These variables will probably soon be obsolete anyway.



-mrt



_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel


--
Jon Trulson

"In the game of chess, you can never let your adversary see your pieces."

                              - Zapp Brannigan


_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

Reply via email to