This one failed to apply, possibly due to the fact Peter already fixed
one of the issues you fixed. It probably just needs to be rebased on
current master.
-jon
On 10/31/18 8:45 AM, Matthew R. Trower wrote:
This patch fixes up some additional regressions introduced in the
various shellcheck patches.
-mrt
d...@blackshard.net (Matthew R. Trower) writes:
Ah, the actual commit in question was
ff17b57585af5c3ce9555b42daf848a89e10effd
whereas this thread refers to
e8e03641214e472288d52a12caa5f1e0bf9f69cd
... so many 'shellcheck' commits. I'm not sure where the thread that
Chase introduced the patch in question is. Hopefully I've given plenty
of information on the situation anyway.
Sorry to spam the list.
-mrt
d...@blackshard.net (Matthew R. Trower) writes:
... my apologies; in the interest of precision, I mispoke here: it
doesn't actually *break* installation per-say; it spits out alarming
amounts of 'kill' spam while sleeping for 6 seconds. I did the sane
thing at this point and mashed Ctrl-C. =)
The rest stands.
-mrt
d...@blackshard.net (Matthew R. Trower) writes:
I'm sorry to report that with this commit, installCDE.src:CleanDaemons()
is utterly broken. It doesn't work at all on any platform, and breaks
installation on non AIX/freebsd/openbsd/netbsd/linux platforms (eg:
sun). On those platforms it tries to kill *all* running processes (!!).
Fortunately, the pipeline has further problems, and bails with an error.
This code at import was originally very simple. Somehow over the years
it got long and crazy. Attached is a patch which returns it to its
simple form, this time with a POSIX pipeline that should run correctly
anywhere (at least any POSIX 2004 platform, BSD, and AIX).
-mrt
Jon Trulson <j...@radscan.com> writes:
Merged to master, thanks!
Sorry for the delay in reviewing these - this week was very busy at $JOB.
-jon
On 08/19/2018 03:02 PM, Chase via cdesktopenv-devel wrote:
1st of four incoming patches
Thank you for your time,
-Chase
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
--
Jon Trulson
"In the game of chess, you can never let your adversary see your pieces."
- Zapp Brannigan
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
