On 11/29/19 9:12 PM, Marcin Cieslak wrote:
> On Fri, 29 Nov 2019, Jon Trulson wrote:
>
>>> #ifndef LinuxDistribution

[...]

>>> - instant tool crashes on locale different than "C"
>>
>> Crap.  That thing is so delicate.
>
> I fixed that now, it was an one-off error.
>
> So, to get things working on Fedora 30 and Centos 7:
>
> - do not forget to install "ncompress"
> - install all locale: for Fedora it's "dnf install glibc-all-langpacks"
> - on Centos 7, I have put the following in the config/cf/host.cf file:
>
> #define LinuxDistribution LinuxRedHat
> #define TCLLib -ltcl8.5
>
> and, most importantly, the attached patch should fix the crash
> during the documentation build.
>

WRT the patch, nice catch, but:

-    stringLength = (3 * strlen(pArgv)) + 3;
+    stringLength = (3 * strlen(pArgv)) + 4;
 
Since worst case is an 8bit char, and it is encoded like \xff (4) + "(1)
+ "(1) + 0 (1), shouldn't that be:

stringLength = (*4* * strlen(pArgv)) + 3;

...?


-- 
Jon Trulson

  "Entropy.  It isn't what it used to be."
                           -- Sheldon

_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

Reply via email to