Hi Chase, a few comments/questions:
1. is this patchset based off of master or the autotools branch? I
would need to know this in order to create a separate branch for
this (which I agree with doing, considering we are essentially
throwing away our own ksh and would then be dependent on someone
else's implementation ).
2. How does the clone/checkout/build experience change? We do not
currently have any git submodules, so checking out and building the
code will different. Could you provide instructions/advice for
others wanting to take a look?
3. I see they still seem to be using iffe and maybe nmake - do they
have any plans for updating the build mechanism(s)?
4. WRT the failing tests - Do they work in our current ksh
implementation? This isn't necessarily a stopper, but would be
important to know.
5. What's your feel for the future of this particular ksh repo... They
do seem to be fixing things, but also mention a lack of activity.
News: https://github.com/ksh93/ksh/blame/master/NEWS
TODO: https://github.com/ksh93/ksh/blob/master/TODO
Seems promising, and no doubt our ksh is on the old side, so it would be
good to get this going if we can...
-jon
On 8/20/20 7:59 PM, Chase via cdesktopenv-devel wrote:
> Hi all,
> So these patches make us use the new ksh93 as a git submodule
> (https://github.com/ksh93/ksh), though I would like this put in its
> own separate branch. Reason being everything is working except two
> test cases, EventHandlerTest and CallDataTest4, both of which crash
> when trying to display environment variables related to callback data,
> the head of the new ksh has been willing to help, but I need to make
> the modifications public, plus I would like any solaris/bsd bugs to be
> ironed out now, as I do not have any way of testing them myself.
>
> Thank you for your time,
> -Chase
>
>
>
>
> _______________________________________________
> cdesktopenv-devel mailing list
> cdesktopenv-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
--
Jon Trulson
"Entropy. It isn't what it used to be."
-- Sheldon
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
