On 1/11/21 2:21 PM, Lev wrote:
> Hi Jon,
>
> Thanks for catching that, it’s building fine on musl with just <time.h>. I’ve 
> attached the rebased patches.

Thanks!  Applied to master.

-jon

> Kind regards,
> Lev
>
>
>
>> On Jan 10, 2021, at 18:23, Jon Trulson <j...@radscan.com> wrote:
>>
>> Hi,
>>
>> Thanks for your contribution.  At a first glance it looks ok, except for 
>> patch 0003:
>>
>>  Author: Lev Kujawski <int...@mailbox.org>
>> Date:   Wed Jan 6 12:13:40 2021 -0700
>>     Define time_t within AccessI.h by including <sys/stat.h>.
>> diff --git a/cde/lib/DtHelp/AccessI.h b/cde/lib/DtHelp/AccessI.h
>> index 4dcc6270..206135e5 100644
>> --- a/cde/lib/DtHelp/AccessI.h
>> +++ b/cde/lib/DtHelp/AccessI.h
>> @@ -44,6 +44,7 @@
>>  #ifndef _DtHelpAccessI_h
>>  #define _DtHelpAccessI_h
>>  
>> +#include <sys/stat.h>
>>  
>>  #ifndef        _XtIntrinsic_h
>>  /*
>>
>>
>> I think this should be:
>>
>> #include <time.h>
>>
>> ... at least for Linux, but definitely not sys/stat.h, which probably 
>> includes time.h indirectly.  Could you try that change and resubmit that 
>> patch? 
>>
>> I've applied the others, thanks!
>>
>> I have not tried a BSD build.
>>
>> -jon
>>
>> On 1/6/21 7:36 PM, Lev via cdesktopenv-devel wrote:
>>> Hello,
>>>
>>> The attached patches are the first of a set fixing various 
>>> incompatibilities between CDE and the musl C library. Musl has become a 
>>> popular alternative to glibc and uClibc, with distributions like Void 
>>> already supporting it for desktop use.
>>>
>>> Advantages of musl include the ease of creating truly standalone static 
>>> binaries (e.g., no attempts to dlopen() incompatible NSS modules), its MIT 
>>> license, its strict conformance to contemporary POSIX standards, and its 
>>> small size.
>>>
>>> Everything within CDE (including documentation) builds successfully, with 
>>> only one minor functional deficiency in the CDE Print Manager, which can no 
>>> longer bind privileged client ports using rresvport().
>>>
>>> Kind regards,
>>> Lev
>>>
>>> I
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> cdesktopenv-devel mailing list
>>>
>>> cdesktopenv-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
>> -- 
>> Jon Trulson
>>
>>   "Entropy.  It isn't what it used to be."
>>                            -- Sheldon
>>
>> _______________________________________________
>> cdesktopenv-devel mailing list
>> cdesktopenv-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

-- 
Jon Trulson

  "Entropy.  It isn't what it used to be."
                           -- Sheldon

_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

Reply via email to