Marcin,
I just ran the test suite and had no failures related to memory allocation, the 
only failure I ran into was this one:
test path begins at 2021-01-17+18:15:48
        path.sh[356]: $SHELL -c of unreadable empty script should fail -- 
expected 126, got /tmp/ksh93.shtests.19281.6143/path.C/script: cannot open 126

Lev,
This is a known issue with upstream ksh93: 
https://github.com/ksh93/ksh/issues/3, maybe I am being a bit inconsiderate, 
but I think that the benefit of us not having to maintain our own decade old 
out of tree fork of ksh93 anymore is a worthy trade off for musl support. Could 
any of your most recent patches be applied upstream? I saw that you did edit a 
few files in the ksh93 tree.


Thank you for your time,
-Chase

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Sunday, January 17, 2021 5:54 PM, Marcin Cieslak <sa...@saper.info> wrote:

> On Sun, 17 Jan 2021, Chase wrote:
>
> > Marcin you were right, it was ast malloc causing problems, I asked the 
> > leader of ksh if there was any way to disable it and he told me to pass 
> > -D_std_malloc. OpenBSD works perfectly now. Patch attached. I think we 
> > could safely merge this branch now if there are no further objections...
>
> Not quite - from what I've read using standard libc malloc breaks ksh93 
> subtly some tests of the test suite
> (haven't check with the fork you are using).
>
> What might happen here is that we pass the area allocated by ksh93 malloc but 
> that
> is about to be released using free() coming from libc...
>
> Thinking a bit about it, this might create bigger problems with dtksh, yuck
>
> Marcin




_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

Reply via email to