On 6 April 2010 11:52, Egon Willighagen <egon.willigha...@gmail.com> wrote: > On Tue, Apr 6, 2010 at 12:43 PM, Noel O'Boyle <baoille...@gmail.com> wrote: >> Between 1.2.4 and 1.2.5 the API lost functionality relating to 2D >> depiction. > > That was actually lost between 1.0 and 1.2. The 1.2.x series was never > able to render molecules/reactions in 2D.
You're absolutely right. My mistake. I've been carrying along a misunderstanding of the version numbering of 1.0 vs 1.2. The original cinfony release using CDK 1.0.x. The following ones used 1.2.x but I retained the drawing code in the hope the functionality would reappear. >> I understand that this was due to a refactoring out to >> JChemPaint, not to fix a grave bug. This forces me to break my own >> promise of a stable API over at Cinfony (removal of the draw() method) >> or else to avoid upgrading to the remainder of the 1.2.x series. > > I am puzzled how you got rendering to work with 1.2.4. >> Simply put, I don't think removal of functionality (or a refactoring) >> should be allowed in a Minor release. > > Indeed. Which was why it was already removed in 1.2.0. >> Instead, the new CDK jar should >> be a drop-in replacement for an existing jar. If there are any >> automatic tools that can be added to nightly to test for API stability >> (or provide a diff of the API), I would encourage you to use them and >> to revert any changes that break the API. > > Agree, but I do not see how this applies to CDK 1.2.5, as none of the > 1.2.4 had 2D depiction functionality. There have been some code bits > around from 1.0 (e.g. IAtomColorer), but nothing as complete as to be > able to render something. > > Last summer I did write a patch that could be used on top of CDK > 1.2.2/.3(?) to make rendering possible, but was not part of a CDK > 1.2.x release itself. > >> Please take these comments as constructive criticism. > > Taken as such. > > Let's try to figure out how you got rendering working with 1.2.4... > > Egon > > -- > Post-doc @ Uppsala University > Proteochemometrics / Bioclipse Group of Prof. Jarl Wikberg > Homepage: http://egonw.github.com/ > Blog: http://chem-bla-ics.blogspot.com/ > PubList: http://www.citeulike.org/user/egonw/tag/papers > ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Cdk-user mailing list Cdk-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cdk-user
