Hello,
Looking at the code in cdrecord\scsi_cdr.c, I have a question about code in
mode_select_g0 and mode_select_g1. In both of the functions there is the
following line:
scmd->cdb.g0_cdb.high_addr = smp ? 1 : 0 | pf ? 0x10 : 0;
It seems to me that the desired result from this would be:
scmd->cdb.g0_cdb.high_addr = (smp ? 1 : 0) | (pf ? 0x10 : 0);
However, since there are no parenthesis I think that the operator
precedence would be:
scmd->cdb.g0_cdb.high_addr = smp ? 1 : (0 | pf) ? 0x10 : 0;
I have not traced the usage of the high_addr field to see if it is really
used anywhere. These routines are also in the libscgcmd\modesense.c
Just checking that the original code is what is intended.
Thanks.
Steve.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Cdrtools-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cdrtools-developers
