> >>         of the -immed flag is  to
> >>         tell  cdrecord  to try to wait short times wile writing
> >>         to the media.
> >>
> >>         As this is an experimental feature, I would like to get feedback.
> 
> >If it's introduced so late and so experimental, then it probably should
> >be denoted with distinct command-line flag.
> 
> >The code in question is engaged only if(verbose). Why? Shouldn't it be
> >engaged regardless verbosity?
> 
> >Some commentary or longer variable names would help to audit the code.
> >After a short look I can't tell when exactly usleep is called... Is it
> >when drive buffer is reported full as one would normally expect?
> 
> The code is audited ;-)

Then why are you asking for feedback;-)

But seriously speaking I'd really like to figure out when exactly usleep
is called. I'd appreciate if you could answer this question in some way
[note that I don't demand an answer, but express an appreciation in case
you would find an opportunity to do so]. "Commentary or longer variable
names" is nothing but an alternative to explicitely answering the
question:-)

> And please note that the -immed flag has been marked experimental too.

Just an extra reason to separate the flags... Indeed, if you expect
people to experiment with it, then it's better to program for maximum
flexibility. Again, it's nothing but *a* feedback:-)

You didn't comment on/answer the 2nd question. I.e. is it intentional
that the code in question is engaged only if(verbose)? If it is, then my
feedback would be "reconsider" as one would normally expect this
functionality to be engaged/disengaged regardless verbosity of the
*informative* output.

Cheers. A.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to