> >> ... the patch does the trick and mkisofs masters correct > >> DVD-Video image, but presumably extra code performing cross-checking is > >> required:-) > > >I have to insist at the very least on the following cross-check. A. > > OK, I did look at this change and it seems that > > 1) The text is wrong: The file related to vts_menu_file is > VIDEO_TS/VTS_%02i_0.VOB and not VIDEO_TS/VTS_%02i_0.IFO
It was not a typo! The message was intended! The idea is if *.IFO has vtsm_vobs==0 and there is a none 0-sized *_0.VOB, then it is *.IFO which is considered corrupted, not *_0.VOB... On the second thought I have to admit that it doesn't have to be wrong... I mean the fact that vtms_vobs==0 doesn't have to mean that *_0.VOB file has to be 0-sized... Or in other words, vtms_vobs==0 surely means that *_0.VOB will never be played, but it doesn't have to mean that the latter has to actually be 0-sized... ***As long as vtstt_vobs checks in sane that is!!!*** Yes, I know it's a *pure* speculation:-) > 2) When manually putting some junk into the file > VIDEO_TS/VTS_%02i_0.VOB the following message is displayed: > > mkisofs: Either VIDEO_TS.IFO or VIDEO_TS.VOB is not of correct size. > mkisofs: Unable to make a DVD-Video image. Which is misleading, don't you think? I mean it could have been more specific and point out VTS_%02i_0.* as guilty one... > So we do not wven come to your check. It seems that this additional code > is not needed and would never be reached. But it might turn out that in order to be more specific in 2), you might have to relax some checks (or will choose to do so for any other reason whatsoever) and then it will be up to proposed "if (DVDFileSize(vts_menu_file)!=0)" to judge if layout is sane. I mean the fact that the code appears redundant *now* doesn't necessarily render it useless for eternity. Yes, *pure* speculation as well:-) Shall we have another look around or are you eager to release it as it is now? A. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
