Danny Backx wrote:
> I've attached a patch.
> 
> Three pieces :
> - be able to quit rshd without rebooting my PDA. Do you have another way
>   to do this?

Just kill the process with synce-pkill, or if you launch it on the
device in PocketCMD.exe or CMD.exe, just CTRL-C it (or press the
red hand - same thing).

Since the main rshd usage it to drive the gdb and gcc testsuites, I'm
afraid the chances of testing an executable named exit.exe are high.

Of course having a control panel applet to start/stop rshd would also be
nice, of just simply a small executable that looks for a running rshd
and kills it, or sends a windows message to it that causes it to kill
itself, or whatever.

> - Error handling at the CreatePipe call. Read the comment, it would be
>   better, in my opinion, to be able to send a string back to the rsh.
>   Do you agree; and if so, shall I make changes in that direction ?

Yes, I agree.  Just pass client_data into create_child instead of
the pipes handle arrays, and then you have access to the sockets.

> - Error handling in PipeLib. On my system, ActivateDevice returns with
>   ERROR_DEVICE_IN_USE if all is well, or with ERROR_FILE_NOT_FOUND if
>   the PipeDev.dll is not installed. (Respectively codes 2404 and 2.)
> 

That would be nice.  But please mind the formatting, and remove the #if
0 dead code.  Also, please provide a changelog entry.

Cheers,
Pedro Alves



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Cegcc-devel mailing list
Cegcc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cegcc-devel

Reply via email to