Danny Backx wrote:
> 
> dannypc: {242} svn diff src/mingw/include/excpt.h
> Index: src/mingw/include/excpt.h
> ===================================================================
> --- src/mingw/include/excpt.h   (revision 1130)
> +++ src/mingw/include/excpt.h   (working copy)
> @@ -101,4 +101,22 @@
>  
>  #endif /* Not RC_INVOKED */
>  
> +#if defined(__MINGW32CE__)

This is ARM specific, not CE specific.  Someone targetting mingw32ce
for anything else than ARM would stumble on this, so better make
it right from the beginning.

> +/*
> + * Inherited from newlib's libc/sys/wince, this happens to match the
> + * w32api include/excpt.h definition.
> + *
> + * Required to write decente exception handlers.
> + *
> + * Note that this definition is known to work for ARM,
> + * and that MSDN documents another definition for 64-bit CPU's,
> + */

Please remove these comments, they add no value once the ARM issue
and the issue below is resolved.

What's funny is that w32api/include/excpt.h doesn't exist upstream
anymore, it was remove over 5 years ago:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/winsup/w32api/ChangeLog?rev=1.182&content-type=text/x-cvsweb-markup&cvsroot=src
http://cygwin.com/ml/cygwin-patches/2002-q2/msg00256.html

It must have ended up in our repository due to merge botch.  Maybe
we have other stalled files too.  For some reason I can't cvs status
right now.  If you're willing, you could confirm that we don't have
anything interesting in that file that's not found in others, remove
it, and rebuild the toolchains from scratch.

-- 
Pedro Alves


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Cegcc-devel mailing list
Cegcc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cegcc-devel

Reply via email to