<Warning, quick 1-minute, not a full review.>
On Tuesday 07 October 2008 00:49:05, Pawel Veselov wrote:
> +#define TRACING(level) ((WCETRACE_DEBUGGER_GET() & level) || \
Can you rename TRACING into something else no so generic, please?
Sounds like asking for trouble down the line.
__WCETRACE_P ?
__WCETRACING ?
(_P is a semi-standard suffix for predicate.)
> + (WCETRACEGET() & level))
> +#define WCETRACE(level, fmt...) do { \
> + if (TRACING(level)) { \
> + __WCETrace((level), fmt); \
Missing ## __VA_ARGS__ ?
> + } } while(0)
> +
--
Pedro Alves
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Cegcc-devel mailing list
Cegcc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cegcc-devel
