On Wed, 2009-04-15 at 23:33 +0200, Ismail Khatib wrote:
> First of all sorry for the form of my last email, I was in a kind of
> strange mood that day.

Don't worry about it. But a patch with comment is infinitely better than
one without :-)

I have questions about your submissions. With some answers, I can commit
stuff to the SVN.

Would it work on your target if we said something like
#ifdef __DARWIN_UNIX03
%token NAME LIBRARY DESCRIPTION LEOPARD_STACKSIZE
%token HEAPSIZE CODE DATAU DATAL
#else
%token NAME LIBRARY DESCRIPTION STACKSIZE HEAPSIZE CODE DATAU DATAL
#endif

and obviously a similar change to the other line ?

> +#ifndef __DARWIN_UNIX03
>  extern int sigaltstack(const struct sigaltstack *, struct sigaltstack
> *);
> +#endif

Can you explain what the __DARWIN_UNIX03 symbol means ? Is it one
specific release of the operating system ? Is it better to use something
like __DARWIN_UNIX or __DARWIN or are there no such things ?


> -WINUSERAPI HMENU WINAPI GetMenu(HWND);
> +/* WINUSERAPI HMENU WINAPI GetMenu(HWND); */
> +#define GetMenu(x) (NULL)

Shouldn't this be

+ #ifndef UNDER_CE
WINUSERAPI HMENU WINAPI GetMenu(HWND);
+ #endif

Any CE application that tries to use GetMenu is invalid so it would be
better not to allow it to compile. Right ?

        Danny
-- 
Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info


------------------------------------------------------------------------------
Stay on top of everything new and different, both inside and 
around Java (TM) technology - register by April 22, and save
$200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
300 plus technical and hands-on sessions. Register today. 
Use priority code J9JMT32. http://p.sf.net/sfu/p
_______________________________________________
Cegcc-devel mailing list
Cegcc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cegcc-devel

Reply via email to