Note that the reason for this oversight is that so far sound sources
have only be
used from xml using the property/action interface. And calling the 'Play' action
or setting/getting any other property that way automatically calls GetSource().

It is only for pure C++ that the property class is a bit lacking.

Greetings,

On Wed, Jun 25, 2008 at 10:49 PM, Jorrit Tyberghein
<[EMAIL PROTECTED]> wrote:
> Yes you are right. GetSoundSource() needs to have a call to GetSource().
>
> I have no time now but I'll try to remember it for tomorrow.
>
> Greetings,
>
> On Wed, Jun 25, 2008 at 10:43 PM, Emanuele Bertoldi <[EMAIL PROTECTED]> wrote:
>> Mmmm, sure? There are 3 methods interested by this purpose:
>>
>> - void SetSoundName(const char* name)
>> - iSndSysSource* GetSoundSource()
>> - bool GetSource()
>>
>> The first and the second are public but the last is private!
>>
>> If I want the sound source i must call "GetSoundSource()", but the
>> current body of this method is (row 143 in "soundfact.h"):
>>
>> virtual iSndSysSource* GetSoundSource () {
>>    return source;
>>  }
>>
>> No call to "GetSource()" is present in this implementation and the user
>> can't call it because it's a private method of "celPcSoundSource"!
>>
>> So if you need to setup a sound you must add, in my opinion, a call or
>> in "SetSoundName(const char* name)" or in "GetSoundSource()" ;)
>>
>> Greetings, Emanuele
>>
>> Jorrit Tyberghein ha scritto:
>>> As I already reported on the bug ticket this is not a bug.
>>> SetSoundName()'s purpose
>>> is *only* to set the name of the sound source. Nothing more. The application
>>> has to call GetSource() to actually setup the sound. So the code is
>>> correct as it is
>>> in svn.
>>>
>>> Greetings
>>
>> -------------------------------------------------------------------------
>> Check out the new SourceForge.net Marketplace.
>> It's the best place to buy or sell services for
>> just about anything Open Source.
>> http://sourceforge.net/services/buy/index.php
>> _______________________________________________
>> Cel-main mailing list
>> Cel-main@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/cel-main
>>
>
>
>
> --
> Project Manager of Crystal Space (http://www.crystalspace3d.org)
> and CEL (http://cel.crystalspace3d.org)
> Support Crystal Space. Donate at
> https://sourceforge.net/donate/index.php?group_id=649
> Visit my town at http://waldir.myminicity.com/
>



-- 
Project Manager of Crystal Space (http://www.crystalspace3d.org)
and CEL (http://cel.crystalspace3d.org)
Support Crystal Space. Donate at
https://sourceforge.net/donate/index.php?group_id=649
Visit my town at http://waldir.myminicity.com/

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Cel-main mailing list
Cel-main@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cel-main

Reply via email to