2011/4/22 res <re...@gmx.ch>
> On 21.04.2011 18:57, vkne...@users.sourceforge.net wrote:
> > Modified: cel/trunk/plugins/propclass/mechanics/mechanics.cpp
> > ===================================================================
> > --- cel/trunk/plugins/propclass/mechanics/mechanics.cpp 2011-04-21
> 16:28:31 UTC (rev 4303)
> > +++ cel/trunk/plugins/propclass/mechanics/mechanics.cpp 2011-04-21
> 16:57:35 UTC (rev 4304)
> > @@ -599,7 +599,7 @@
> > mechsystem = 0;
> >
> > forceidseed = 1;
> > - last_tag = csArrayItemNotFound;
> > + last_tag = 0;
>
> csArrayItemNotFound is ~0. Which is not 0.
> A “last” value of ~0 suggests that “tag” might have a valid (possibly
> even initial) value of 0. So the change of last_tag may break some logic.
>
> -f.r.
>
Yes, I know there's a difference.
>From what I've seen, the forceidseed is used as starting value,
then is incremented each time a tagged force is created.
I'll try to have a deeper look at this in the week-end,
also check if last_tag used to be a size_t.
Would that (change last_tag to size_t) be more correct ?
------------------------------------------------------------------------------
Fulfilling the Lean Software Promise
Lean software platforms are now widely adopted and the benefits have been
demonstrated beyond question. Learn why your peers are replacing JEE
containers with lightweight application servers - and what you can gain
from the move. http://p.sf.net/sfu/vmware-sfemails
_______________________________________________
Cel-main mailing list
Cel-main@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cel-main
