Really nice work, thanks for myself. I need writing drivers sometimes, but I am always googling for the facilities I need, putting all in together is a good idea, nice start point for a complete driver.
On Tue, Oct 2, 2012 at 2:01 AM, Constantine Shulyupin <co...@makelinux.com>wrote: > You got the main idea. It is supposed to be best practices example. > I am not sure that it is need to be mainlined , because: > 1. Its is more difficult to maintain it in the mainline. > 2. The driver works with demo application and test script, which can't > be efficiently mainlined. > > I haven’t tried to mainline it. > > I would expect more feedback from other developers to make it real > best practices example. > > Thanks > > On Tue, Oct 2, 2012 at 12:26 AM, Tim Bird <tim.b...@am.sony.com> wrote: > > On 10/1/2012 4:43 AM, Constantine Shulyupin wrote: > >> > >> Hi, > >> I develop LDT - Linux Driver Template. It can used as starting pint of > >> development custom device driver and for learning development of Linux > >> device drivers. > >> > >> Documentation: https://github.com/makelinux/ldt/blob/master/README.md > >> > >> The driver uses following Linux facilities: module, platform driver, > >> file operations (read/write, mmap, ioctl, blocking and nonblocking > >> mode, polling), kfifo, completion, interrupt, tasklet, work, kthread, > >> timer, misc device, proc fs, UART 0x3f8, HW loopback, SW loopback, > >> ftracer. > >> > >> To test the driver just run > >> git clone git://github.com/makelinux/ldt.git&& cd ldt&& ./ldt-test > >> > >> > >> You feedback, suggestions, discussions, recommendations patched will > >> be greatly appreciated! > >> > > I don't write many drivers, but this seems like it's very useful > > as example code. I think there might even be value in mainlining > > it. In my opinion, a lot of copy-and-paste happens in kernel > > development, but it's hard to know if the code being copied > > really implements the "best practices" for using the different > > facilities and APIs in the kernel. (I was disappointed when > > I found out that the scull device driver sample from the > > Linux Device Drivers book wasn't mainlined.) > > > > Have you tried to mainline this? > > > > Whether it gets mainlined or not, it's probably worth referencing > > as example code. Maybe we should put up a wiki page directing > > people to it? > > -- Tim > > > > > > > > > > -- > Constantine Shulyupin > http://www.MakeLinux.com/ > Embedded Linux Systems, > Device Drivers, TI DaVinci > _______________________________________________ > Celinux-dev mailing list > Celinux-dev@lists.celinuxforum.org > https://lists.celinuxforum.org/mailman/listinfo/celinux-dev >
_______________________________________________ Celinux-dev mailing list Celinux-dev@lists.celinuxforum.org https://lists.celinuxforum.org/mailman/listinfo/celinux-dev
