On 00:45 Sun 07 Oct     , Constantine Shulyupin wrote:
> Hi,
> 
> Thanks to Baruch Siach, Thomas Petazzoni, Jean-Christophe
> PLAGNIOL-VILLARD, Peter Korsgaard, Ezequiel Garcia,  Selim TEMUR and
> Tim Bird who sent feedback on LDT announce!
> 
> With you help I've made following updates:
> - created new page http://elinux.org/Device_drivers with list of all
> mentioned and discovered driver samples and skeletons for video, usb,
> network, including updated examples from book LDD3. You are welcome to
> update the list.
> - added multiple char devices with Device Model support, debugfs and
> other small fixes to https://github.com/makelinux/ldt/
don't take it bad but this kind of example will never make it mainline

it's wrote in the right way
> 
> I absolutely agree that LDT can't be universal template. First of all
> it is better to fork a new driver from similar existed driver or use
> subsystem template. But sometimes it is easier to write driver from
> scratch than rework existed. It this case LDT can be useful.
no sorry you miss the point here it's better to based your work on a clean
driver so you can see how it's supposed to be written
> 
> If you think that there is lack of subsystem driver template, please
> write me. I have some free time to write it.
> 
> LDT is more just char UART device driver. UART is used only for sample
> and can be replaced with another HW interface. Also LDT provides a lot
> of most common device driver infrastructure: bottom halves, kthread,
> synchronization, memory, mmap and ioctl interfaces.
> Finally, only LDT can be executed and tested by running a single
> script https://github.com/makelinux/ldt/blob/master/ldt-test, which
> send data to driver and check driver's response.
I'm sorry but you code can not be useed as a recommandation for people to
write new drivers. Read a mainline will be better and will show practice we
use right now such as we de not use ifdef is the as muchas possible we use
IS_ENABLED & co and for the UART Russel King the ARM Maintainer si currently
reworking the tty API and I can point others suach PM, DT etc...

Best Regards,
J.
_______________________________________________
Celinux-dev mailing list
Celinux-dev@lists.celinuxforum.org
https://lists.celinuxforum.org/mailman/listinfo/celinux-dev

Reply via email to