> CellML Automated Notifications wrote: > > Author: agarny > > Date: 2008-01-04 00:50:37 +1300 (Fri, 04 Jan 2008) > > New Revision: 2054 > > > > Modified: > > CellML_DOM_API/trunk/CIS/sources/CISImplementation.cxx > > CellML_DOM_API/trunk/configure.ac > > Log: > > 64-bit related issues: > > > > - Updated configure.ac with the -fPIC flag so that it is consistent with > what is done for PCEnv > > - Updated CIS so that it compiles a model using the -fPIC flag, so that > the compiled model can be used within PCEnv > > > > > > Modified: CellML_DOM_API/trunk/CIS/sources/CISImplementation.cxx > > =================================================================== > > --- CellML_DOM_API/trunk/CIS/sources/CISImplementation.cxx 2008-01-03 > 10:29:40 UTC (rev 2053) > > +++ CellML_DOM_API/trunk/CIS/sources/CISImplementation.cxx 2008-01-03 > 11:50:37 UTC (rev 2054) > > @@ -87,7 +87,7 @@ > > #ifdef WIN32 > > "-mno-cygwin -mthreads -Llib -lcis-0 " > > #else > > - "-nodefaultlibs -Llib -lcis " > > + "-nodefaultlibs -Llib -lcis -fPIC " > > #endif > > "-O3 " > > #ifdef ENABLE_FAST_MATH > > > > Modified: CellML_DOM_API/trunk/configure.ac > > =================================================================== > > --- CellML_DOM_API/trunk/configure.ac 2008-01-03 10:29:40 UTC (rev > 2053) > > +++ CellML_DOM_API/trunk/configure.ac 2008-01-03 11:50:37 UTC (rev > 2054) > > @@ -315,7 +315,7 @@ > > > > AM_CXXFLAGS="$AM_CXXFLAGS $VISIBILITY_FLAGS" > > > > -CXXFLAGS="$CXXFLAGS $EXTRA_OPTIMISATION" > > +CXXFLAGS="$CXXFLAGS -fPIC $EXTRA_OPTIMISATION" > > CFLAGS="$CFLAGS $EXTRA_OPTIMISATION" > > > This is not really a very good way of writing a configure script - -fPIC > is a gcc specific option, it certainly doesn't mean anything to other > compilers, including important ones to us like cl. > > It seems we just get a warning from cl when doing a Win32 build: > "Warning: Unrecognised option -fPIC" > > Still, I am not sure that we should put compiler-specific flags into a > compiler-general part of the configure script. I have also yet to check > whether -fPIC actually affects the 32 bit build on Linux - I think it > will probably slow it down unnecessarily but I suspect that it will > still work. However, it is still probably better not to use that flag > unless we actually need it, which would mean detecting the platforms on > which it is needed and treating them differently.
Yes and this is exactly why I said (in a message sent to the CellML tools developers mailing list) that " I have committed my changes, but they are very much minimal so it would be easy to revert anything I have done, should that be required". In other words, I was perfectly aware that my 'solution' might not be perfect, but I wanted to share it with you guys, so you could at least see what I had to do to get things to compile under Ubuntu x64. > I filed tracker item 320 on this. Thanks, Alan. _______________________________________________ cellml-discussion mailing list [email protected] http://www.cellml.org/mailman/listinfo/cellml-discussion
