I noticed a consistent use of comments didn't match a consistent
coding of the calculation being commented. This is definitely core,
so the code is probably correct. Just a heads up:
In ceph_calc_file_object_mapping():
First usage:
/* bl = *off / su; */
t = off;
do_div(t, su);
bl = t;
Second usage:
/* *oxoff = *off / layout->fl_stripe_unit; */
t = off;
*oxoff = do_div(t, su);
The second usage assigns to 'oxoff' the remainder of division, not
the quotient.
-n
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ceph-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ceph-devel
