On Mon, Mar 08, 2010 at 10:18:11PM +0000, Sage Weil wrote: > > > > The patch for qemu-0.12.3 is attached. I would appreciate it if someone > > with a deeper understanding of the signal handling in librados and/or > > kvm could have a look. > > Yehuda is taking a look at it now. The signals are used to wake up > blocking read()/write()/connect(), but we should be able to use poll() or > select() instead (and clean things up in the process).
Great! - That was really a quick response. I will check out the current git version tomorrow and will give it a try. > I would number the objects in hex so that it's easier to translate a block > or byte offset to an object (maybe just sprintf(n, "%s.%08llx", ...)). > And then name the metadata object something more explicit, like > %s.head or %s.metadata or something along those lines. > > Also, the object size should probably be a parameter in the header object, > so that you can specify whatever stripe size you want when creating the > device (4MB is somewhat arbitrary). The same goes for the block size too, > I guess (is 4K a more reasonable default?). OK. I will do that. (I'm not sure about how kvm handles the block size, but I'll look into it). > Is there any particular reason to restrict the 'device name' to 12 chars? On the ceph blog I have read that the name of an object is a fixed-size 20 byte identifier. That's why I've chosen to use a base64 encoded sequence number. This sequence number requires 8 bytes to store, so there are 12 bytes left for the 'device name'. If this is no longer a restriction, using longer names (with a hex encoding of the sequence number) would make sense. Christian ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Ceph-devel mailing list Ceph-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ceph-devel
