On Fri, 2010-03-26 at 12:17 -0700, Sage Weil wrote:
> On Fri, 26 Mar 2010, Yehuda Sadeh Weinraub wrote:
> > On Sun, Mar 14, 2010 at 9:14 AM, Christian Brunner <c...@muc.de> wrote:
> > >
> > > Attached is an updated version of my rados kvm driver. I did the following
> > > changes:
> > >
> >
> > We tested it and it looks great. We were working on a native linux
> > rados block device, and it'll be great if it would be compatible with
> > the kvm one. There were some fairly minor issues that were related to
> > the header. This is the modified metadata header that we're currently
> > using:
> >
> > struct rbd_obj_header_ondisk {
> > char text[64];
> > char signature[4];
> > char version[8];
> > __le64 image_size;
> > char obj_order;
>
> Maybe
> unsigned char obj_order;
>
> > unsigned char crypt_type;
> > unsigned char comp_type;
>
> or __u8 for all of these?
>
> > __le16 snap_count;
> > __le32 snap_id[0];
>
> Make this:
> __le64 snap_seq;
> __le16 snap_count;
> __le64 snap_id[0];
>
> > } __attribute__((packed));
Fixed.
Thanks!
Yehuda
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ceph-devel mailing list
Ceph-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ceph-devel
