On Wed, Oct 20, 2010 at 9:32 AM, Colin McCabe <[email protected]> wrote:
> I wish we didn't have to have a callback just to get the buffer we're
> trying to write into. It feels like that should somehow be grouped
> with the rest of the transaction data. Why can't we add it to
> Objector::Op's constructor, for example. There must be some obvious
> reason but I don't see it yet.
That wouldn't work if we were sending a message that didn't go through
the Objecter, like any messages to the MDS. So getting buffers from
out of the Messenger is going to require a callback in some form, and
about all we can guarantee is that we'll have a tid, since that's part
of the Messenger interface.
We could conceivably add a function pointer to the Message class, and
use it to obtain buffers for responses to that Message. This actually
might work out better since it allows finer-grained decisions about
memory allocation?
-Greg
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
