On 12/09/2010 04:09 AM, Daniel P. Berrange wrote: > On Mon, Dec 06, 2010 at 04:24:09PM +0900, MORITA Kazutaka wrote: >> This patch adds network disk support to libvirt/QEMU. The currently >> supported protocols are nbd, rbd, and sheepdog. The XML syntax is like >> this: >> >> <disk type="network" device="disk"> >> <driver name="qemu" type="raw" /> >> <source protocol='rbd|sheepdog|nbd' name="...some image identifier..."> >> <host name="mon1.example.org" port="6000"> >> <host name="mon2.example.org" port="6000"> >> <host name="mon3.example.org" port="6000"> >> </source> >> <target dev="vda" bus="virtio" /> >> </disk> >> >> docs/schemas/domain.rng | 31 +++++++
Hmm; missing a corresponding update to docs/formatdomain.html.in to
document the new XML.
> ACK
NACK. After applying this patch, I get 'make check' failures:
TEST: vmx2xmltest
/bin/sh: line 5: 15285 Segmentation fault (core dumped)
abs_top_builddir=`cd '..'; pwd` abs_top_srcdir=`cd '..'; pwd`
abs_builddir=`cd '.'; pwd` abs_srcdir=`cd '.'; pwd` CONFIG_HEADER="`cd
'..'; pwd`/config.h"
PATH="$abs_top_builddir/src:$abs_top_builddir/daemon:$abs_top_builddir/tools:$PATH"
SHELL="/bin/sh"
LIBVIRT_DRIVER_DIR="/home/remote/eblake/libvirt/src/.libs" LC_ALL=C
${dir}$tst
FAIL: vmx2xmltest
TEST: xml2vmxtest
...!!!!!!!!!!...............!!!!!!!!!.. 39 FAIL
I haven't looked into root cause. Kazutaka, would you mind preparing a v3?
--
Eric Blake [email protected] +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
