On Fri, Apr 22, 2011 at 08:44:49AM -0700, Sage Weil wrote:
> - We can easily wrap the non-fast past with a mutex to avoid the races 
> (because, again, collisions are vanishingly rare except in our test 
> cases).

How do you guard against crashes, e.g. the create+set_xattr crashing
before set_xattr?

How do you guard against gaps in the sequence number thing? (Perhaps
make that part a random string, and change consumers to listdir
instead of probing 1,2,3...)

How do you convince yourself you've covered all the races?

> - For simplicity, I still think the simplest thing will be to push all the 
> escaping/mangling into one layer.  Once place to audit and unit test.

I think the big functional benefit with that is that you can have the
suffix not be obscured by the hash; FOO_a43fec_n_head not FOO_a43fec_n

-- 
:(){ :|:&};:
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to