On Thu, 28 Apr 2011, Colin Patrick McCabe wrote: > > The "remove this" comment on libceph_initialized cannot be blindly > > acted on; similar logic could be pushed down into ceph::crypto::init, > > though. > > > > This is ugly, but it's the best I could do. Please go through the code > > and let me know if you have any ideas on how to make it less painful. > > Daemonization should be done in common_init. Obviously, only daemons > will do it!
Well, probably after that. There is a lot of initialization that intentionally runs before daemonization (so that you get feedback on errors, etc.). > Daemonization has nothing to do with the messenger logically, so it > will be good to get that stuff out of there. Yeah. SimpleMessenger::start() basically does some checks, forks, and then starts a thread. The forking bit can be moved out, and I think most of the checks are obsolete anyway. sage -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
