Re: [PATCH 2/2] libceph: fix handle_timeout() racing with con_work()/try_write()

[Jim Schutt]

Sage Weil wrote:

I pushed a patch to the msgr_race branch that catches all four cases (I think). Does the fix make sense given what you saw?

Sorry, I haven't completed much testing; it took me a while
to figure out the fix needs this:

diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
index 9c0a9bd..b140dd3 100644
--- a/net/ceph/messenger.c
+++ b/net/ceph/messenger.c
@@ -2013,6 +2013,7 @@ done:
        mutex_unlock(&con->mutex);
 done_unlocked:
        con->ops->put(con);
+       return;

 fault:
        mutex_unlock(&con->mutex);


Still testing....

Thanks -- Jim

Thanks!
sage

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html