Use kmemdup rather than duplicating its implementation The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Thomas Meyer <[email protected]> --- diff -u -p a/net/ceph/crypto.c b/net/ceph/crypto.c --- a/net/ceph/crypto.c 2011-11-07 19:38:30.130592543 +0100 +++ b/net/ceph/crypto.c 2011-11-08 10:58:06.915274800 +0100 @@ -15,10 +15,9 @@ int ceph_crypto_key_clone(struct ceph_cr const struct ceph_crypto_key *src) { memcpy(dst, src, sizeof(struct ceph_crypto_key)); - dst->key = kmalloc(src->len, GFP_NOFS); + dst->key = kmemdup(src->key, src->len, GFP_NOFS); if (!dst->key) return -ENOMEM; - memcpy(dst->key, src->key, src->len); return 0; } -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
