On Sat, 21 Apr 2012, wrote: > Hi, everyone. > > While reading crush_remove_tree_bucket_item, I found that removed > items will still occupy its original position in the tree, but set its > weight to 0.
Yes.. moving items around can result in shifted data. > And in crush_add_tree_bucket_item, why don't we reuse these items with > 0 weight since I don't see additional data migration if we reuse these > nodes? Lazy implementation. Ideally we should reuse those slots. Patches welcome! In most cases, people are probably well-served by the straw bucket, though, so this may not matter too much. sage -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
