Sage Weil <s...@inktank.com> writes: > Hi Miklos, > > I've updated the ceph code to take better advantage of the new > ->atomic_open(), but ran into several bumps understanding the new > interface. If you don't mind, can you make sure I got it right? > > Basically: > > - on success, > return finish_open(original file, original dentry, ...)
Yes. > - on symlink, > return finish_no_open(original file, original dentry) That should be "return finish_no_open(original file, NULL)" > - if we have to splice in a different dentry (e.g., d_splice_alias()), > return finish_no_open(original file, existing dentry) Yes. > - on ENOENT, > return finish_no_open(original file, original negative dentry) Again, NULL indicates "original dentry". > > Basically, give finish_no_open whatever ->lookup() would have returned. > Is that right? Yes, exactly. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
