On Wed, 22 Aug 2012, Daniel Baluta wrote: > On Tue, Aug 14, 2012 at 4:27 PM, Iulius Curt <[email protected]> wrote: > > From: Iulius Curt <[email protected]> > > > > Make ceph_monc_do_poolop() static to remove the following sparse warning: > > * net/ceph/mon_client.c:616:5: warning: symbol 'ceph_monc_do_poolop' was > > not > > declared. Should it be static? > > > > Signed-off-by: Iulius Curt <[email protected]> > > --- > > net/ceph/mon_client.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/ceph/mon_client.c b/net/ceph/mon_client.c > > index 105d533..3875c60 100644 > > --- a/net/ceph/mon_client.c > > +++ b/net/ceph/mon_client.c > > @@ -613,7 +613,7 @@ bad: > > /* > > * Do a synchronous pool op. > > */ > > -int ceph_monc_do_poolop(struct ceph_mon_client *monc, u32 op, > > +static int ceph_monc_do_poolop(struct ceph_mon_client *monc, u32 op, > > u32 pool, u64 snapid, > > char *buf, int len) > > { > > -- > > 1.7.9.5 > > > > -- > > Hi Sage, > > Can you have a look on this? :)
Sorry, this one fell through the cracks. Yes, we can switch it to static, but while we're doing that let's drop the ceph_monc_ prefix too (since it's private). Thanks! sage -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
