I was just take a look at this for libcephfs. Does it make sense to have ceph_release free CephContext, and ceph_unmount with everything else: client, messenger, and mon client?
- Noah On Wed, Oct 24, 2012 at 4:32 PM, Noah Watkins <[email protected]> wrote: > On the Java, side being able to do an unmount to free resources, while > still keeping the context, makes things more natural to both explain, > and code. I'm sure this would be true for other language bindings as > well. > > +1 > > > On Wed, Oct 24, 2012 at 4:17 PM, Sage Weil <[email protected]> wrote: >> I'm annoyed that ceph_shutdown() both unmounts and releases the resource, >> but there is a separate _create() and _mount() method. I wonder if it >> makes sense to introduce ceph_umount() and ceph_release() and make >> ceph_shutdown() call them (for compatibility). >> >> I thought librados was a bit cleaner, but it appears to be doing the same >> thing.. meh. (Also, the docs for _shutdown() incorrectly state that >> shutdown isn't needed if rados_connect() fails.. but presumably the >> resource still needs to be freed?) >> >> Is this worth fixing? >> >> sage >> -- >> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in >> the body of a message to [email protected] >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
