On 11/29/2012 07:01 PM, Andrey Korolyov wrote: > On Thu, Nov 29, 2012 at 8:34 PM, Sage Weil <s...@inktank.com> wrote: >> On Thu, 29 Nov 2012, Andrey Korolyov wrote: >>> $ ceph osd down - >>> osd.0 is already down >>> $ ceph osd down --- >>> osd.0 is already down >>> >>> the same for ``+'', ``/'', ``%'' and so - I think that for osd subsys >>> ceph cli should explicitly work only with positive integers plus zero, >>> refusing all other input. >> >> which branch is this? this parsing is cleaned u pin the latest >> next/master. >> >> > > It was produced by 0.54-tag. I have built > dd3a24a647d0b0f1153cf1b102ed1f51d51be2f2 today and problem has > gone(except parsing ``-0'' as 0 and 00000/0000001 as 0 and 1 > correspondingly).
We use strtol() to parse numeric values, and '-0', '00000' or '00001' are valid numeric values. I suppose we could enforce the argument to be numeric only, hence getting rid of '-0' and enforce stricter checks on the parameters to rule out valid numeric values that look funny, which in the '0*\d' cases it should be fairly simple. -Joao -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
