From: "Yan, Zheng" <[email protected]> commit 1203cd2110 (mds: allow open_remote_ino() to open xlocked dentry) makes Server::handle_client_rename() xlocks remote inodes' primary dentry so witness MDS can open xlocked dentry. But I added remote inodes' projected primary dentries to the xlock list. This is wrong because projected dentries are invisible for path traverse.
Signed-off-by: Yan, Zheng <[email protected]> --- src/mds/Server.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mds/Server.cc b/src/mds/Server.cc index ebdbfe4..eced76f 100644 --- a/src/mds/Server.cc +++ b/src/mds/Server.cc @@ -5351,9 +5351,9 @@ void Server::handle_client_rename(MDRequest *mdr) // open_remote_ino() with 'want_locked=true' when the srcdn or destdn // is traversed. if (srcdnl->is_remote()) - xlocks.insert(&srci->get_projected_parent_dn()->lock); + xlocks.insert(&srci->get_parent_dn()->lock); if (destdnl->is_remote()) - xlocks.insert(&oldin->get_projected_parent_dn()->lock); + xlocks.insert(&oldin->get_parent_dn()->lock); } // we need to update srci's ctime. xlock its least contended lock to do that... -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
