Hi Matt!
I took a closer look at the libcephfs branch you guys have. A copy is in
wip-libcephfs in the main ceph.git, and I opened a pull request on github
just to capture review comments. Please take a look at
https://github.com/ceph/ceph/pull/318
Lots of small questions and issues, but overall the appraoch looks great.
I also rebased/squashed teh changes into a separate set of patches that
try to capture the logical changes (instead of the patchset evolution)..
these are in wip-libcephfs-rebased.
Can you take a look?
I think the ideal path forward (at least from my perspective :) would be:
- diff the rebased branch with yours to make sure the things i dropped
aren't important.
- make sure teh 'reject' patches are unimportant, and drop them from the
series. the objecter change would fall into this category..
- address the review comments, modifying the rebased patches as
appropriate
- fix up the patch changelogs to have proper authorship and (where
appropriate) any background/justification for the change. (in several
cases I was guessing what the change was about)
- rebase onto current master branch
- submit a new github pull request
- profit!
One way or another, I'd love to get this stuff upstream.
Thanks-
sage
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
