Hi David,

In

int FileStore::lfn_open(coll_t cid,
                        const ghobject_t& oid,
                        bool create,
                        FDRef *outfd,
                        IndexedPath *path,
                        Index *index)
{
  assert(get_allow_sharded_objects() || oid.shard_id == ghobject_t::NO_SHARD);
  assert(outfd);

would it make sense to

assert(get_allow_sharded_objects() || ( oid.shard_id == ghobject_t::NO_SHARD) 
&& oid.generation == ghobject_t::NO_GEN) )

instead ?

Cheers

-- 
Loïc Dachary, Artisan Logiciel Libre
All that is necessary for the triumph of evil is that good people do nothing.

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to