On 02/21/2014 12:55 PM, Ilya Dryomov wrote:
> Hello,
>
> This series adds support for CEPH_OSD_OP_SETALLOCHINT osd op to libceph
> along with adjusting rbd to make use of it. The rationale and the
> basic desing was outlined in the "rados io hints" thread on ceph-devel
> about a month ago.
It looks like some of this discussion is still active, so it
might be a little premature to implement this. That being said,
I reviewed what you have. Overall it looks good to me. I have
some small suggestions for you to consider. I also think that
in this case just extending the definition of a write request
is preferable to encoding this stuff in a distinct new op, but
I may be missing some information.
-Alex
>
> Thanks,
>
> Ilya
>
>
> Ilya Dryomov (6):
> libceph: encode CEPH_OSD_OP_FLAG_* op flags
> libceph: add support for CEPH_OSD_OP_SETALLOCHINT osd op
> libceph: bump CEPH_OSD_MAX_OP to 3
> rbd: do not hard-code CEPH_OSD_MAX_OP in rbd_osd_req_callback()
> rbd: num_ops parameter for rbd_osd_req_create()
> rbd: prefix rbd writes with CEPH_OSD_OP_SETALLOCHINT osd op
>
> drivers/block/rbd.c | 90
> ++++++++++++++++++++++++++++-----------
> include/linux/ceph/osd_client.h | 12 +++++-
> include/linux/ceph/rados.h | 10 ++++-
> net/ceph/osd_client.c | 32 ++++++++++++++
> 4 files changed, 117 insertions(+), 27 deletions(-)
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
